London 9 -Marziyeh Azhdari - JS-Core-1 - Week 1 by MariAzhdari · Pull Request #429 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

MariAzhdari · 2022-11-22T22:26:26Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name: Marziyeh Azhdari
Your City:London
Your Slack Name:MariAzh

Homework Details

Module:JS
Week:1

Notes

What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?

Gayle-Thompson-Igwebike

Great job Marziyeh. Well done.

Gayle-Thompson-Igwebike · 2022-11-25T15:41:27Z

-
+let first="Hello, my name is "
+let myName="Mari"
+let message=first+myName


I like how you concatenated the first+myName in the variable. I did it the very long way.... This is good.

Gayle-Thompson-Igwebike · 2022-11-25T15:57:40Z

@@ -1,5 +1,7 @@
 // Write your function here
+function greeting(name){
+ console.log("Hello,my name is ;"+(name));


Hi Marziyeh, Just looking at this code and I thought, I would have written it like this:
console.log("Hello, my name is " + name);

What do you think?

exactly.Thanks, Gayle.

Gayle-Thompson-Igwebike · 2022-11-25T16:03:21Z


-function convertToUSD() {}
+function convertToUSD(price) {
+  return price*1.4


I like this syntax...mine was sooo long... Great job.

mcarballopacheco · 2022-12-01T22:27:23Z

@@ -1 +1,6 @@
 console.log("Hello world");
+console.log("cd exercises/B-hello-world")


Interesting test! I hope you realised that this will still just print "cd exercises/B-hello-world", even if this command has a very different meaning when you run it in the console, that is, this will not change directory when run inside the console.log as a string.

mcarballopacheco · 2022-12-01T22:31:11Z

+let myName="mari"
+let lengthName=myName.length
+// let messageTwo=`my name is${myName}and my name is${lengthName}characters long`
+let message="        My name is"+myName+" and my name is " + lengthName+" characters long"


This is a very small comment, but you should try to be consistent with your style. If you are putting spaces before and after the plus signs, for example. is" + myName + " an you should do that for all strings concatenations.

I used the .trim method to remove the extra whitespace for this I made space. so I should do that for all strings concatenations??

Thanks @mcarballopacheco Your suggestion is quite right. I'm practising consistency also. Javascript is soo hard for me

mcarballopacheco · 2022-12-01T22:36:17Z

+let total=numberOfMentors+numberOfStudents
+let percentageOfStudent=numberOfStudents/total*100;
+console.log("Percentage students: "+Math.round(percentageOfStudent)+"%");
+let PercentageMentors=100-percentageOfStudent


You could have also calculated the percentage of mentors, as.
let PercentageMentors=numberOfMentors/total*100;
and then use round. Surprisingly, this may not always be the same as the way you calculated it, because if the fraction ends in 0.5, it will always go up to the next integer when using Math.round. This is why in general, it is important to be aware and careful when rounding up numbers.

I got it thanks.

mcarballopacheco · 2022-12-01T22:39:24Z

@@ -1,5 +1,7 @@
 // Write your function here
+function greeting(name){
+ console.log("Hello,my name is ;"+ name);


I think here it would have make more sense based on the exercise to return the greeting and then use console.log() outside of the function.

function greeting(name){
return name;
}
console.log("Hello,my name is ;"+greeting("Daniel"));

Is it ok?

mcarballopacheco · 2022-12-01T22:41:14Z

 // Call the function and assign to a variable `sum`

-console.log(sum);
+console.log(sum(13,124));


This will work, but in the exercise it mentioned to assign the value to a variable called sum, so:
let sum = add(13, 124)
console.log(sum)

mcarballopacheco · 2022-12-01T22:44:01Z

+function result(name){
+    return console.log(greeting(name));
+}
+result(mentor1);


This looks great!

mcarballopacheco · 2022-12-01T22:50:16Z

 // Why can this code be seen as bad practice? Comment your answer.
+//there are three functions that are not necessary and I think it is possible with a shorter code as well.(I am not sure!!!!!!!!!!!!!!!!!)
 let badCode =



It is in general a bad idea to call many functions in the same line. It makes the code very hard to read. A better idea is to call each function once in a line and assign the result to a variable which then gets called in the following like but the next function, etc.

mcarballopacheco · 2022-12-01T22:57:54Z

@@ -1,17 +1,24 @@
 // Add comments to explain what this function does. You're meant to use Google!
+//The Math.random() function returns a floating-point, pseudo-random number that's greater than or equal to 0 and less than 1,
 function getRandomNumber() {


I think here, the question is asking what does the getRandomNumber() does also?

mcarballopacheco · 2022-12-01T23:03:09Z


-function addTaxAndFormatCurrency() {}
+function addTaxAndFormatCurrency(price) {
+   return `£${(price * 1.2).toFixed(2)}`;


You should have used the calculateSalesTax function that you just created. The reason we create functions is to not repeat code which minimises errors. For example, let say the sales tax changes from 20% to 25%. if all of the times you calculated the sales tax you always use the calculateSalesTax function, then you only need to change the calculation in one place only. But if you are calculating in different places, then you would have to find them one by one.

mcarballopacheco

Amazing work Mari!

MariAzhdari added 3 commits November 21, 2022 14:51

JavaScript-Core-1-Coursework-Week1

ab10183

London 9 -Marziyeh Azhdari - JS-Core-1 - Week 1

c0a17a6

week 1

ae16177

Gayle-Thompson-Igwebike reviewed Nov 25, 2022

View reviewed changes

Update exercise3.js

c661982

mcarballopacheco reviewed Dec 1, 2022

View reviewed changes

		@@ -1 +1,6 @@
		console.log("Hello world");
		console.log("cd exercises/B-hello-world")

Uh oh!

Conversation

MariAzhdari commented Nov 22, 2022

Your Details

Homework Details

Notes

Uh oh!

Gayle-Thompson-Igwebike left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MariAzhdari Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gayle-Thompson-Igwebike Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcarballopacheco Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcarballopacheco left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MariAzhdari Nov 28, 2022 •

edited

Loading

Gayle-Thompson-Igwebike Dec 1, 2022 •

edited

Loading

mcarballopacheco Dec 1, 2022 •

edited

Loading